Skip to content

fix #11518: update Insight UI context menu tests#1606

Merged
jburel merged 2 commits intoome:dev_4_4from
mtbc:insight-ui-menu-tests-11518
Oct 17, 2013
Merged

fix #11518: update Insight UI context menu tests#1606
jburel merged 2 commits intoome:dev_4_4from
mtbc:insight-ui-menu-tests-11518

Conversation

@mtbc
Copy link
Copy Markdown
Member

@mtbc mtbc commented Oct 10, 2013

Insight's UI changed and the context menu tests had to change accordingly. This required extension of functionality so that the relevant keywords could work down into submenus.

This PR should fix https://trac.openmicroscopy.org.uk/ome/ticket/11518 to make ./build.py -f components/tests/ui/build.xml ui-test-insight -DTEST=menus pass.

In general, the tests seem to pass far more reliably locally than on Hudson.

@jburel
Copy link
Copy Markdown
Member

jburel commented Oct 16, 2013

./build.py -f components/tests/ui/build.xml ui-test-insight -DTEST=menus
Buildfile: /Users/jburel/Documents/git-repo/openmicroscopy/components/tests/ui/build.xml
Entering /Users/jburel/Documents/git-repo/openmicroscopy/components/tests/ui...

ui-test-insight:
Entering /Users/jburel/Documents/git-repo/openmicroscopy/components/tests/ui...

run_folder_insight:
==============================================================================
Menus                                                                         
==============================================================================
Menus.Context-Menus                                                           
==============================================================================
Enabled Menu Items :: check that context menu items are correctly ... | PASS |
------------------------------------------------------------------------------
Menus.Context-Menus                                                   | PASS |
1 critical test, 1 passed, 0 failed
1 test total, 1 passed, 0 failed
==============================================================================
Menus                                                                 | PASS |
1 critical test, 1 passed, 0 failed
1 test total, 1 passed, 0 failed
==============================================================================

@jburel
Copy link
Copy Markdown
Member

jburel commented Oct 16, 2013

@mtbc, @sbesson:

http://hudson.openmicroscopy.org.uk/view/All/job/OMERO-merge-robotframework-stable/92/

*sys-package-mgr*: processing new jar, '/opt/hudson/workspace/OMERO-merge-robotframework-stable/lib/repository/swinglibrary-1.6.0a.jar'
*sys-package-mgr*: can't write cache file for '/opt/hudson/workspace/OMERO-merge-robotframework-stable/lib/repository/swinglibrary-1.6.0a.jar'
*sys-package-mgr*: processing modified jar, '/System/Library/Java/Extensions/QTJava.zip'
*sys-package-mgr*: can't write cache file for '/System/Library/Java/Extensions/QTJava.zip'
*sys-package-mgr*: can't write index file
==============================================================================
Menus                                                                         
==============================================================================
Menus.Context-Menus                                                           
==============================================================================
Enabled Menu Items :: check that context menu items are correctly ... | PASS |
------------------------------------------------------------------------------
Menus.Context-Menus                                                   | PASS |
1 critical test, 1 passed, 0 failed
1 test total, 1 passed, 0 failed
==============================================================================
Menus                                                                 | PASS |
1 critical test, 1 passed, 0 failed
1 test total, 1 passed, 0 failed
==============================================================================

The failure of the job is not related to the PR. It is due to a missing jar see gh-1628

@jburel
Copy link
Copy Markdown
Member

jburel commented Oct 17, 2013

@sbesson
Copy link
Copy Markdown
Member

sbesson commented Oct 17, 2013

From [http://hudson.openmicroscopy.org.uk/view/Failing/job/OMERO-merge-robotframework-stable/95],

==============================================================================
Menus                                                                         
==============================================================================
Menus.Context-Menus                                                           
==============================================================================
Enabled Menu Items :: check that context menu items are correctly ... | PASS |
------------------------------------------------------------------------------
Menus.Context-Menus                                                   | PASS |
1 critical test, 1 passed, 0 failed
1 test total, 1 passed, 0 failed
==============================================================================
Menus                                                                 | PASS |
1 critical test, 1 passed, 0 failed
1 test total, 1 passed, 0 failed
==============================================================================

and under components/tests/ui/target/reports/insight/menus/output.xml

<suite source="/opt/hudson/workspace/OMERO-merge-robotframework-stable/components/tests/ui/testcases/insight/menus/context-menus.txt" id="s1-s1" name="Context-Menus">
<test id="s1-s1-t1" name="Enabled Menu Items">
...
<status status="PASS" critical="yes" endtime="20131017 07:23:26.943" starttime="20131017 07:23:21.825"></status>
</test>

Apart from the unrelated SAX exception, this is ready to merge.

jburel added a commit that referenced this pull request Oct 17, 2013
fix #11518: update Insight UI context menu tests
@jburel jburel merged commit ce0dded into ome:dev_4_4 Oct 17, 2013
@mtbc mtbc deleted the insight-ui-menu-tests-11518 branch October 17, 2013 15:04
@mtbc
Copy link
Copy Markdown
Member Author

mtbc commented Oct 17, 2013

--rebased-to #1636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants