Skip to content

Feature/import standalone#17

Merged
chris-allan merged 16 commits intoome:developfrom
jburel:feature/importStandalone
Oct 30, 2011
Merged

Feature/import standalone#17
chris-allan merged 16 commits intoome:developfrom
jburel:feature/importStandalone

Conversation

@jburel
Copy link
Copy Markdown
Member

@jburel jburel commented Oct 21, 2011

The code is now ready for review (story #6653)

  • initial tests done by @qidane (Andrew) and @omeroscott.
  • Scott will go through a second review (see #7063)
  • possible to build it directly from ant.

…t i.e. editor, importer, main view (close #6654)
…t i.e. editor, importer, main view (close #6654)
…oscopy into feature/importStandalone

Conflicts:
	components/insight/SRC/org/openmicroscopy/shoola/agents/fsimporter/ImporterAgent.java
	components/insight/SRC/org/openmicroscopy/shoola/agents/fsimporter/view/ImporterComponent.java
	components/insight/SRC/org/openmicroscopy/shoola/agents/fsimporter/view/ImporterControl.java
	components/insight/SRC/org/openmicroscopy/shoola/agents/fsimporter/view/ImporterModel.java
	components/insight/SRC/org/openmicroscopy/shoola/agents/fsimporter/view/ImporterUI.java
	components/insight/SRC/org/openmicroscopy/shoola/env/Environment.java
	components/insight/SRC/org/openmicroscopy/shoola/env/LookupNames.java
	components/insight/config/container.xml
@omeroscott
Copy link
Copy Markdown

Closed #7063 no further comments

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Oct 27, 2011

@joshmoore. All tests/validation done by @omeroscott.

TODO: check windows build

@chris-allan
Copy link
Copy Markdown
Member

@jburel: Played with this a bit yesterday and today. Looks great. Only thing that I can see we are lacking are the previously requested set of options for the "P/D or S" selection panel: forcing of dimensions, selection of Image name lengths, etc. Add tickets to #6653 and then we merge this in?

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Oct 29, 2011

@chris-allan, The options are available in the "options" tab. A new location was selected following user feedback.
There is an on-going discussion about where to put the "tag+other metadata" at import. That's a larger question requiring more information from various site (e.g. Imperial).

@chris-allan
Copy link
Copy Markdown
Member

@jburel: A ha, didn't see that there. Merging this, we can discuss more details about that tab in the office on Monday.

chris-allan added a commit that referenced this pull request Oct 30, 2011
@chris-allan chris-allan merged commit 17b0f3a into ome:develop Oct 30, 2011
sbesson pushed a commit to sbesson/openmicroscopy that referenced this pull request Jun 1, 2012
Add figure scripts test & fix file creation bug #9014
joshmoore added a commit to snoopycrimecop/openmicroscopy that referenced this pull request Jan 15, 2013
Handle case when import canditates return no import containers.
snoopycrimecop pushed a commit to snoopycrimecop/openmicroscopy that referenced this pull request Aug 15, 2016
Remove windows from doc.
joshmoore pushed a commit that referenced this pull request Sep 17, 2018
Use thumbnail direct loading without duplicate logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants