Skip to content

Static build year#2149

Merged
joshmoore merged 7 commits intoome:developfrom
joshmoore:static-build-year
Mar 17, 2014
Merged

Static build year#2149
joshmoore merged 7 commits intoome:developfrom
joshmoore:static-build-year

Conversation

@joshmoore
Copy link
Copy Markdown
Member

In a follow-on from gh-2173, the year shouldn't be completely dynamic, but rather generated at build time.

Testing in Python:

$ bin/omero shell
In [1]: from omero_version import build_year
In [2]: print build_year
2014

In the web, "© 2007-2014 University of Dundee & Open Microscopy Environment" should be shown.

@will-moore should be happy with the code.

@will-moore
Copy link
Copy Markdown
Member

You'll need to add 'build_year' to the context in webgateway/views.py def full_viewer() at:

https://github.com/openmicroscopy/openmicroscopy/blob/develop/components/tools/OmeroWeb/omeroweb/webgateway/views.py#L1669

@joshmoore
Copy link
Copy Markdown
Member Author

Done.

@ximenesuk
Copy link
Copy Markdown
Contributor

@will-moore ping

@will-moore
Copy link
Copy Markdown
Member

Good to merge.

@bpindelski
Copy link
Copy Markdown

This being a rather compact PR and reviewed - can it be merged?

joshmoore added a commit that referenced this pull request Mar 17, 2014
@joshmoore joshmoore merged commit 62f4e53 into ome:develop Mar 17, 2014
@joshmoore joshmoore deleted the static-build-year branch March 17, 2014 09:06
@joshmoore
Copy link
Copy Markdown
Member Author

--rebased-to #2170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants