Minor adjustments for imagej-omero (rebased onto develop)#2263
Merged
joshmoore merged 4 commits intoome:developfrom Apr 9, 2014
Merged
Minor adjustments for imagej-omero (rebased onto develop)#2263joshmoore merged 4 commits intoome:developfrom
joshmoore merged 4 commits intoome:developfrom
Conversation
Member
Author
|
--rebased-from #2173 |
Member
|
Following instructions on #2173 this seems fine. Stdout and Stderr files generated as expected and OMERO_HOME is available to script. |
joshmoore
added a commit
that referenced
this pull request
Apr 9, 2014
…0.1.0 Minor adjustments for imagej-omero (rebased onto develop)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as gh-2173 but rebased onto develop.
Various small fixes and improvements found while working on https://github.com/imagej/imagej-omero/issues?milestone=3&state=open with @ctrueden.
For review:
OMERO_HOMEshould have no impact on scripts. (In fact, it can likely be considered part of the public API) /cc @will-moorebin/omero script params /test.pyshould now print out both stdout and stderr to help in debugging (See 'Can't find params' should list stdout file ID imagej/imagej-omero#18)org.bushelikely isn't needed, but as we will need to consider which logback configuration we're going to pass to background Java tasks.Happy to break this up if need be, but I wanted to get it open for discussion.