Admin move to group 12305

[will-moore]

This fixes the list of Groups available for an Admin when they right-click and "Move to Group". Now we only show the groups that the Admin is a member of.

This is a partial fix for http://trac.openmicroscopy.org.uk/ome/ticket/12305

To test, log in as Admin, right click on Dataset or Image -> Move to Group.
List of groups should only be the ones that the Admin is a member of.

[kennethgillen]

@will-moore isn't it possible to add scrolling to the list or some other UI feature? I might wish to actually put some data in a user's group, no? Instead of fixing my ability to choose the group, I'm having the functionality removed.

[will-moore]

I don't have much control over those right-click menus. They are a jsTree widget. Adding scrolling to hierarchical lists is tricky (see my attempt at the Groups/Users dropdown). Also, if you moved your own data to a group that you are not a member of, it would effectively disappear (you would have no way to access it) so this is really a bug not a feature.
The more important missing feature is moving data belonging to another user: https://trac.openmicroscopy.org.uk/ome/ticket/10588. This will involve a change to the UI anyway, which will remove the list of Groups from the right-click menu and put it all in a dialog (same as Insight). This will also fix the problem with long group lists.

[gusferguson]

@will-moore
Tested using Gretzky user-6 private-1 and read-annotate-1.
Works as expected.
Good to merge.

[pwalczysko]

Unfortunately, now with rc2 on gretzky this turns out to have fatal consequences for the group choice menu (all on gretzky, user-6, try to change a group, looking for read-only-1(.
The list is either incomplete, or (certainly) completely non-ordered (and thus I cannot find read-only in the list at all ).

[pwalczysko]

On a second look, I think I can find all what is there - it is just not in the right order (which it used to be before this PR was merged).

[pwalczysko]

@joshmoore @jburel @sbesson : @will-moore is looking into it right now, I think it would be good to have this fixed for 5.0.2

[will-moore]

Fix in #2546

[will-moore]

--rebased-to #2557