Preview resize 12319#2597
Merged
joshmoore merged 2 commits intoome:dev_5_0from Jul 4, 2014
Merged
Conversation
Member
|
Seems to work fine, good to merge. (Small RFE I noticed: tall, thin images are shrunk more than necessary so as to fit in the square view port thing -- it narrows as necessary but also shrinks vertically when maybe it needn't.) |
Member
|
Works nicely although I couldn't resize window on IE8 & 9, only 10 |
Member
Author
Member
|
that seems to be true for regular image, but not big image |
Member
Author
|
Ah, OK. Seems that neither left nor right panels can be resized once a Big Image is displayed in Preview panel in IE8 (needs a full page refresh to fix). But this bug is not related to this PR. Can we merge now and fix that later? |
Member
|
ok, np, please create a ticket for that |
Member
Author
|
Ticket created https://trac.openmicroscopy.org.uk/ome/ticket/12412 |
Member
|
Thanks all. Merging. |
Member
|
--rebased-to #2762 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The Preview viewport should now resize when the right panel is resized.
To test: