Sprint5 server bugs

[joshmoore]

These are issues found during the last round of testing of the server.

• 9632 - data in the system group loaded by root caused an exception. (integration test now passes)
• 9635 - the canEdit flag on objects was being corrupted. Non-deterministic behavior in the web UI should now be gone.

[chris-allan]

All the fixes surrounding #9632 seem to be working nicely. The last two commits (2482a7f, 3cc848b) were not in the build today, right @joshmoore?

[joshmoore]

@chris-allan, correct. Adding comment to description now.

[jburel]

@joshmoore, @chris-allan: Will check difference between both clients

[jburel]

@chris-allan, @joshmoore: tested in both clients with various permissions level and user's roles. No problem noticed now. Updating testing setup sheet

[jburel]

@joshmoore, @chris-allan: found a problem

• Log in as user-5
• Add read-write group to display
• View data of user-4
• Cannot edit name of user-4's data. In theory I should. Screenshot added to #9635

[jburel]

@joshmoore: similar problem in web

• Read-write group logged in as user-5
• Cannot edit data of user-4. Lock icon

Problem seems only to be for read-write, read-annotate seems fine.

[joshmoore]

Do you mean "read-write-1"? It's currently listed as rwra:

omero@gretzky:~$ OMERO-CURRENT/bin/omero group list
Using session 64b4f491-a37a-4c91-8241-347dd3d3e94a (user-5@localhost:4064). Idle timeout: 10.0 min. Current group: read-write-1
 id  | name                                 | perms  | # of owners | # of members 
-----+--------------------------------------+--------+-------------+--------------
 0   | system                               | rw---- | 1           | 2            
 1   | user                                 | rwr-r- | 0           | 29           
 2   | guest                                | rw---- | 0           | 1            
 3   | read-write-1                         | rwra-- | 2           | 5            
 4   | read-annotate-1                      | rwra-- | 2           | 5    

[joshmoore]

(and user-5 is only a member, not an owner of that group)

[jburel]

@joshmoore: that will explain, another problem in the setup script. It should be rwrw--. Other tests/reports are potentially not valid, need to check

[jburel]

@joshmoore: doc updated ome/omero-documentation#92
testing setup too.

[jburel]

@joshmoore: I have set correctly the permissions of read-write. Now it works as expected.