Skip to content

Enable 'Show ROIs' after loaded#4082

Merged
joshmoore merged 1 commit intoome:dev_5_1from
will-moore:show_rois_after_loading_12983
Aug 25, 2015
Merged

Enable 'Show ROIs' after loaded#4082
joshmoore merged 1 commit intoome:dev_5_1from
will-moore:show_rois_after_loading_12983

Conversation

@will-moore
Copy link
Copy Markdown
Member

See http://trac.openmicroscopy.org/ome/ticket/12983

This ensures that the "Show ROIs" button is not enabled until the image has loaded since it fails if used before then (noted on Big Images in particular).

To test:

  • Open a Big Image with ROIs in the main image viewer.
  • Note that the "Show ROIs" link doesn't become enabled until the viewer has loaded.
  • Try to click it before and after loading. Should only work after loading and ROIs should load OK.

This has been cherry-picked to the jstree_2015 branch:
will-moore@a487600

--no-rebase

@will-moore will-moore changed the title Imageviewer enable 'Show ROIs' after loaded. See #12983 Enable 'Show ROIs' after loaded Aug 21, 2015
@gusferguson
Copy link
Copy Markdown

@will-moore

Tested with trout merge on Mac -Safari and Windows 8 - IE 10 user-3 read-only-1

Behaves as expected.
Good to merge.

joshmoore added a commit that referenced this pull request Aug 25, 2015
@joshmoore joshmoore merged commit cea5adf into ome:dev_5_1 Aug 25, 2015
@will-moore will-moore mentioned this pull request Aug 25, 2015
@sbesson sbesson added this to the 5.1.4 milestone Sep 21, 2015
@will-moore will-moore deleted the show_rois_after_loading_12983 branch February 18, 2019 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants