Skip to content

Ice 3.6#4452

Merged
joshmoore merged 33 commits intoome:developfrom
jburel:ice36
Apr 28, 2016
Merged

Ice 3.6#4452
joshmoore merged 33 commits intoome:developfrom
jburel:ice36

Conversation

@jburel
Copy link
Copy Markdown
Member

@jburel jburel commented Jan 31, 2016

Changes required to support ice 3.6
I open so we can test the 3.5 clients against 3.6 server

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Feb 6, 2016

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Feb 17, 2016

Test failures are due to the fact that the root session is closed. This was not properly handled with previous versions of ice. The fault is in our testing framework. Fixing the issue.

@jburel jburel force-pushed the ice36 branch 4 times, most recently from 86b2224 to 269dda8 Compare April 22, 2016 11:31
@jburel jburel removed the breaking label Apr 22, 2016
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Apr 22, 2016

icemock retrieval from artifactory does not really work. But we could certainly get rid of that jar.
Not something to do in that PR.

@jburel jburel force-pushed the ice36 branch 2 times, most recently from 8113609 to 3cbdf9e Compare April 25, 2016 11:57
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Apr 25, 2016

keeping the mock for 3.5 and 3.6.2 for now since they are required to pass travis. No problem noticed when builing locally w/o the mock.jar. They are retrieved from artifactory.

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Apr 28, 2016

@pwalczysko: could you indicate on the PR the outcome of the last round of testing?

@pwalczysko
Copy link
Copy Markdown
Member

@joshmoore
Copy link
Copy Markdown
Member

🎉 Thanks, @jburel! Merging.

Looking over the commits, looks like we're waiting on a small number of Ice fixes:

  • double-quote issue
  • tls1_1 version max
  • whatever required the generation of osxtemplate.xml

Anything else?

@joshmoore joshmoore merged commit 56e71c2 into ome:develop Apr 28, 2016
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Apr 28, 2016

removal of icemocks usage (us)

@jburel jburel added this to the 5.2.3 milestone May 4, 2016
@sbesson sbesson modified the milestones: 5.3.0, 5.2.3 May 10, 2016
@sbesson sbesson modified the milestones: 5.3.0, 5.2.3 Sep 10, 2016
@jburel jburel deleted the ice36 branch January 13, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants