Add get OriginalFileContent.m for possible consumption by getFileAnnotationContent#4502
Add get OriginalFileContent.m for possible consumption by getFileAnnotationContent#4502jburel merged 4 commits intoome:developfrom
Conversation
| % Input check | ||
|
|
||
| if ~isa(originalFile, 'omero.model.OriginalFileI'), | ||
| assert(isLoadedFA(fileAnnotation),... |
There was a problem hiding this comment.
|
Reads fine to me. Do you want to simplify https://github.com/openmicroscopy/openmicroscopy/blob/v5.2.2/components/tools/OmeroM/src/annotations/getFileAnnotationContent.m#L55 to call |
|
I can do but it's tricky for me to test. Is it tested automatically? |
|
Conflicting PR. Removed from build OMERO-DEV-merge-push#257. See the console output for more details.
|
|
Conflicting PR. Removed from build OMERO-DEV-merge-push#258. See the console output for more details.
|
sbesson
changed the title
|
@imunro: Needs relisting for review? |
|
Well spotted Mark thanks. |
|
Example is green, works as expected. Updating the retrieval to large files will probably be part of the "download" epic unless @sbesson has already a card. |
| % Read data and cast into int8 | ||
| fid = fopen(path, 'w'); | ||
| byteArr = store.read(0,originalFile.getSize().getValue()); | ||
| fwrite(fid,byteArr,'*uint8'); |
There was a problem hiding this comment.
@imunro: sorry for missing this change when the PR was reviewed. What is the rationale for using *uint8 instead of int8? Note this casting has caused some regressions https://www.openmicroscopy.org/community/viewtopic.php?f=6&t=8117
There was a problem hiding this comment.
If there was a rationale I certainly can't remember it now. My suspicion is that I copied from some code I already had working. Sorry about the regression.
6 participants
Add get OriginalFileContent.m for possible consumption by getFileAnnotationContent