Show image.name fix

[will-moore]

This fixes a lot of "show" functionality that was broken with the new jsTree in 5.2.x as noticed in #4534 (comment)

To test:

• check that all the examples in OMERO.web show extensions (develop) #2611 are working, that urls load and select the specified items.
• Select multiple wells in Plate, copy link url, paste in browser and check that it loads and selects the same wells.
• Repeat for multiple Images in a Dataset

I will also add Robot tests to this PR...

[will-moore]

Robot tests are passing: https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-robotframework/257/robot/Web%20&%20Web/Web_1/Show%20Test/

[pwalczysko]

The first three commands from Chris's PR do not work on cowfish connected to eel-merge

/webclient/?show=project.id-1
/webclient/?show=project.name-foo
/webclient/?show=tag.textValue-bar

The constructed urls look like
https://cowfish.op...py.org/merge/webclient/?show=project.id-1207 - this Project exists, it belongs to the user who is logged in. Despite this, I am getting 404. (note that I replaced in the address above the word openmicroscopy.
The same experience with the subsequent two commands.
Will stop here - it seems something is seriously wrong here.
Interestingly, the "default" url to find the project when taken from the UI itself by clicking onto the chain link works fine.

[will-moore]

These are working for me (user-3)

• https://cowfish.openmicroscopy.org/merge/webclient/?show=dataset.id-7401
• https://cowfish.openmicroscopy.org/merge/webclient/?show=project.name-imagej_test
• https://cowfish.openmicroscopy.org/merge/webclient/?path=plate.name=uniqueName
• https://cowfish.openmicroscopy.org/merge/webclient/?path=plate.name=uniqueName|well.name-A1
• https://cowfish.openmicroscopy.org/merge/webclient/?path=plate.name=uniqueName|well-312861
• https://cowfish.openmicroscopy.org/merge/webclient/?path=run=1802|well.name-A2

This is not working:

• https://cowfish.openmicroscopy.org/merge/webclient/usertags/?show=tag.textValue-dm3
  since webclient/api/paths_to_object/?tag=36403 returns no paths.
  Will check this with Tag tree actions #4518

NB: when using the obj.name, names need to be unique.

[will-moore]

Have now fixed the show=tag.textValue-foo in #4534 so all should be working now.

[pwalczysko]

Works as expected.

[atarkowska]

@will-moore request.REQUEST is counted as bug now.

[sbesson]

@aleksandra-tarkowska: is there a way to flag these e.g. in the Travis build?

[atarkowska]

grep ?

[sbesson]

Possibly although using grep will not scale as you need to maintain a list of deprecated features/bugs. Browsing quickly, it might be possible long-term to pass a -Werror flag to python manage.py test which will fail on deprecation errors. This is not critical and might be easier to implement if we re-architecture the components but worth keeping in mind.

[joshmoore]

write a flake check and use "# noqa" in the deprecated cases?