Skip to content

Get ROI count#4548

Closed
dominikl wants to merge 2 commits intoome:developfrom
dominikl:get_roi_count
Closed

Get ROI count#4548
dominikl wants to merge 2 commits intoome:developfrom
dominikl:get_roi_count

Conversation

@dominikl
Copy link
Copy Markdown
Member

At the moment Insight loads all ROIs and counts them on the client side for showing the number of ROIs in the right hand side meta data panel. This PR adds a method for directly getting the number of ROIs via an HQL query.

Test: Check some images with ROIs, make sure the ROI count (right hand side metadata panel) is correct.

@dominikl dominikl force-pushed the get_roi_count branch 2 times, most recently from af28406 to d9653dd Compare March 30, 2016 10:18
@dominikl
Copy link
Copy Markdown
Member Author

Should I open it against regions branch? That was my initial intention, but then I thought, it might be good to get it into develop, that's why I openend the PR against develop for now.

@mtbc
Copy link
Copy Markdown
Member

mtbc commented Mar 31, 2016

Just be aware that if these are classes you're also changing on regions then there may well be awkward conflicts to resolve: not a showstopper, but takes extra effort. My policy lately has largely been to do stuff on develop only for bugfixes or for classes I don't expect us to touch on regions before dev_5_2 is branched but conflicts aren't necessarily terrible, they just take a bit of effort and thought, up to you to judge if it's worth it.

* The {@link SecurityContext}
* @param imageId
* The image Id
* @return See above
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably mention it returns -1 in case of error

@dominikl
Copy link
Copy Markdown
Member Author

You were right, it conflicts with my regions PR. I'll close this PR and open it against regions. Can be back ported to develop later anyway, if needed.

@dominikl
Copy link
Copy Markdown
Member Author

Moved to regions branch, see #4550

@dominikl dominikl closed this Mar 31, 2016
@dominikl dominikl deleted the get_roi_count branch April 15, 2016 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants