Full viewer button link#4563
Merged
jburel merged 4 commits intoome:developfrom Apr 18, 2016
Merged
Conversation
will-moore
changed the title
Member
|
The UI part works as expected. |
Member
Author
|
Fixed Robot tests failing at https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-robotframework/267/robot/ |
Member
Author
|
All these tests now passing again: https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-robotframework/268/robot/ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://trello.com/c/vRHQSsTs/59-full-viewer-button-to-be-link and #4558
This PR makes the thumbnails and the Full Viewer buttons into html
<a>links which means you can right-click and "Open link in new tab".To test:
Also check that other clicks on thumbnails and button are still working OK - E.g. double-click thumb to open image in new window, selecting images, shift-select range of thumbs etc.