Skip to content

Get ROI count #4602

Merged
jburel merged 6 commits intoome:developfrom
dominikl:get_roi_count_develop
Apr 27, 2016
Merged

Get ROI count #4602
jburel merged 6 commits intoome:developfrom
dominikl:get_roi_count_develop

Conversation

@dominikl
Copy link
Copy Markdown
Member

@dominikl dominikl commented Apr 22, 2016

Same as #4550 rebased to develop.

Testing: See #4602 (comment)

@jburel jburel added the develop label Apr 23, 2016
@gusferguson
Copy link
Copy Markdown

@dominikl

Tested with
OMERO.insight-5.2.2-393-e464f65-ice36-b292-win
OMERO.insight-5.2.2-393-e464f65-ice35-b292-win
eel user 3 read-only

There is no way to test the ROI folder count with this, as there are no folders.
Did a general check of Measurement Tool functionality - all behaves as normal except for one issue:

  • graph pane selected - selection of ROI gives correct display of histogram and so on
  • select different ROI - graph pane does not update - need to click second time on image to trigger update (any event - even deselecting ROI)
  • appears confined to Graph pane - Inspector pane updates as expected.

I seem to remember this happening before with a PR that changed the updating in a different area.

parallels desktop

parallels desktop

@dominikl
Copy link
Copy Markdown
Member Author

Sorry, I probably should have made this clearer in the PR description. It's just about the "ROI count" display in the metadata panel, nothing in the measurement tool is touched (i.e. also none of the known bugs in the tool are fixed by this PR).
screen shot 2016-04-25 at 09 25 02

@gusferguson
Copy link
Copy Markdown

@dominikl

Retested looking at ROI count in RHP of main window.

Behaves as expected when saving or deleting ROIs in Full Viewer - updates correctly ROI number in RHP.

ROI count does not update in RHP when Yes selected on save prompt when closing Full Viewer with unsaved ROIs.

@dominikl
Copy link
Copy Markdown
Member Author

Thanks @gusferguson . Fixed the issue with the last commit. ROI count should now also update, when the ROIs are saved via the Save Dialog which pops up when you close the image.

@dominikl dominikl force-pushed the get_roi_count_develop branch 2 times, most recently from e055ce2 to 81a2781 Compare April 25, 2016 14:12
@dominikl dominikl force-pushed the get_roi_count_develop branch from 81a2781 to 491fa1e Compare April 26, 2016 10:36
@gusferguson
Copy link
Copy Markdown

@dominikl

Tested using OMERO.insight-5.2.2-423-d82c1c8-ice36-b294-mac eel user-3 read-only-1

Behaves as expected.
Good to merge.

@jburel
Copy link
Copy Markdown
Member

jburel commented Apr 27, 2016

Thanks

@jburel jburel merged commit 266f52c into ome:develop Apr 27, 2016
@jburel jburel added this to the 5.2.3 milestone May 4, 2016
@sbesson sbesson modified the milestones: 5.3.0, 5.2.3 Sep 10, 2016
@dominikl dominikl deleted the get_roi_count_develop branch May 3, 2017 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants