Roi popupmenu fix

[dominikl]

The ROI context menu didn't work properly when triggered by right click on the ROIs in the image viewer. See respective point on checklist on the Trello card - ROI Folders Insight Bugs/RFEs This PR fixes the problems.

Test: Check that the ROI context menu triggered from the image viewer works like the context menu triggered from the ROI table (and that both work like expected).

[gusferguson]

@dominikl

Tested using OMERO.insight-5.3.0-m2-99-8fc6db6-ice35-b113-mac regions-omero.docker.openmicroscopy.org DB: user-14

Behaves as expected.
Good to merge.

[dominikl]

Sorry, @pwalczysko discovered a few more inconsistencies. Has to be re-reviewed, because I added the the bugfix commit to this PR, otherwise I would create merge conflicts.

Test (Last three items on Trello checkbox):

• Check that "Create Folder" item is enabled on all items (ROIs, Shapes and Folders), for single item selection as well as multi-selection.
• Check that "Remove from Folder" is only enabled when a ROI is selected which is in a folder.

[pwalczysko]

All works as expected, including the bugs fixed by the last commits #4612 (comment) and also tested the Default loading of the folders - also as expected.

Ready to merge.

[sbesson]

/home/slave/workspace/OMERO-build/src/components/insight/SRC/org/openmicroscopy/shoola/agents/measurement/util/roimenu/ROIPopupMenu.java:89: warning - @param argument "controller" is not a parameter name.

[dominikl]

Thanks @sbesson . Just fixed the comment, no re-testing necessary.