Skip to content

Roi table improvements#4624

Merged
sbesson merged 3 commits intoome:regionsfrom
dominikl:roi_table_improvements
May 9, 2016
Merged

Roi table improvements#4624
sbesson merged 3 commits intoome:regionsfrom
dominikl:roi_table_improvements

Conversation

@dominikl
Copy link
Copy Markdown
Member

@dominikl dominikl commented Apr 29, 2016

Some more improvements/bug fixes with respect to ROI Folders handling, see Trello - ROI Folders Insight Bugs/RFEs.

  • Enable Drag/Drop only on the first column of the ROI table
  • If a Folder name matches the filter expression, don't filter the sub folders, always show them.

@gusferguson
Copy link
Copy Markdown

@dominikl
Tested using regions-omero.docker.openmicroscopy.org DB: user-14:
OMERO.insight-5.3.0-m2-344-3a2679e-ice35-b132-mac
and
OMERO.insight-5.3.0-m2-344-3a2679e-ice35-b132-win

Behaves as expected.
Note - Drag and Drop does not work for moving ROIs/folders inside folders —> orphaned - presume this is intended behaviour.
Filtering works as expected.
Good to merge.

@gusferguson
Copy link
Copy Markdown

@dominikl @pwalczysko

Just noticed that filtering is disabled if Show All ROIs is checked.
This is contrary to the workflow described in Petr's scenario https://www.openmicroscopy.org/private/ome-internal/testing_scenarios/ROIFolders.html Point 5.

I think you should be able to filter when Show All ROIs is checked - i.e. as per scenario.

id- 18 20110209_region1_1505_atp zvi

@gusferguson
Copy link
Copy Markdown

@dominikl @pwalczysko

Sorry - I see that I have misunderstood the scenario. The behaviour is the same as the scenario.

Probably better to leave as it is and I will see if I can suggest a clarification for the scenario.

@dominikl
Copy link
Copy Markdown
Member Author

dominikl commented May 9, 2016

DnD moving of ROIs and folders inside folders should work, too. They should only become orphaned when dropped into the empty space of the ROI table. I'll check that again.

@gusferguson
Copy link
Copy Markdown

@dominikl - you are correct - it does work - I was not dragging far enough. Sorry!

Good to merge.

@sbesson sbesson merged commit cee0b21 into ome:regions May 9, 2016
@sbesson sbesson added this to the 5.3.0 milestone May 10, 2016
@dominikl dominikl deleted the roi_table_improvements branch May 3, 2017 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants