Skip to content

have AbstractServerTest.resetGroupPerms use Chmod2#4634

Merged
sbesson merged 1 commit intoome:regionsfrom
mtbc:have-tests-use-Chmod2
May 6, 2016
Merged

have AbstractServerTest.resetGroupPerms use Chmod2#4634
sbesson merged 1 commit intoome:regionsfrom
mtbc:have-tests-use-Chmod2

Conversation

@mtbc
Copy link
Copy Markdown
Member

@mtbc mtbc commented May 5, 2016 •
edited
Loading

Attempts to correct failing tests in RenderingSettingsServicePermissionsTest.

@mtbc
have AbstractServerTest.resetGroupPerms use Chmod2
e47291b 
previously used admin service's updateGroup
@mtbc
Copy link
Copy Markdown
Member Author

mtbc commented May 5, 2016

I am open to simply removing and inlining the method if that is preferred, it's called only once.

@sbesson
Copy link
Copy Markdown
Member

sbesson commented May 5, 2016

Interestingly with this PR and #4633 and without #4632, all Java integration tests pass. Will relaunch the test suite with the latter PR included to bissect the cause of the RenderingSettingsServicePermissionsTest failures.

@sbesson sbesson mentioned this pull request May 5, 2016
Closed
@sbesson
Copy link
Copy Markdown
Member

sbesson commented May 6, 2016

If AbstractServerTest.resetGroupPerms is effectively used in one class, I vote for removing it and migrating it it to the corresponding tests. This can be done in a follow-up PR. Integrations tests are now happily passing with this included.

@sbesson sbesson merged commit 668400f into ome:regions May 6, 2016
@mtbc mtbc deleted the have-tests-use-Chmod2 branch May 6, 2016 09:36
@sbesson sbesson added this to the 5.3.0 milestone May 10, 2016
@mtbc mtbc mentioned this pull request May 10, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mtbc @sbesson