Allow non digits (rebased onto develop)#5018
Merged
jburel merged 3 commits intoome:developfrom Jan 13, 2017
atarkowska:rebased/develop/allow_non_digits
Merged
Allow non digits (rebased onto develop)#5018jburel merged 3 commits intoome:developfrom atarkowska:rebased/develop/allow_non_digits
jburel merged 3 commits intoome:developfrom
atarkowska:rebased/develop/allow_non_digits
Conversation
Merged
Member
Author
|
--rebased-from #5014 |
Member
|
Conflicting PR. Removed from build OMERO-DEV-merge-push#558. See the console output for more details.
|
Member
|
Conflicting PR. Removed from build OMERO-DEV-merge-push#559. See the console output for more details.
|
atarkowska
commented
Jan 9, 2017
| # The nodes of the tree that will be initially open based on the | ||
| # nodes that are initially selected. | ||
| self._initially_open = None | ||
| self._initially_open = list() |
Member
Author
There was a problem hiding this comment.
we need to be careful how do we declare vars cc @will-moore
Member
|
Travis status, e.g. |
Member
|
Works fine, robot tests and "show" tests passing. Good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as gh-5014 but rebased onto develop.
What this PR does
This PR clean up console.logs and allow non digits to be passed as initially selected tree elements. see ome/omero-mapr#12