Skip to content

Filter by crash#5120

Merged
jburel merged 1 commit intoome:developfrom
jburel:insight-filterby-crash
Feb 24, 2017
Merged

Filter by crash#5120
jburel merged 1 commit intoome:developfrom
jburel:insight-filterby-crash

Conversation

@jburel
Copy link
Copy Markdown
Member

@jburel jburel commented Feb 23, 2017

What this PR does

Fix crash if no node found when trying to filter by

Testing this PR

  • Log as root
  • Select a dataset with images w/o any rating e.g. see screenshot below
  • Select for example * or better
  • The application should no longer crash

selectionforpr

Related reading

Problem noticed while reviewing gh-4694

cc @dominikl

@jburel jburel added the develop label Feb 23, 2017
@jburel jburel merged commit 785ceb2 into ome:develop Feb 24, 2017
@jburel jburel added this to the 5.3.0 milestone Mar 29, 2017
@jburel jburel deleted the insight-filterby-crash branch August 1, 2017 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants