Skip to content

render.py: new CLI plugin for dealing with rendering settings (manual rebase onto metadata52) (rebased onto metadata53)#5215

Merged
joshmoore merged 26 commits intoome:metadata53from
atarkowska:rebased/metadata53/metadata52-render
Apr 7, 2017
Merged

render.py: new CLI plugin for dealing with rendering settings (manual rebase onto metadata52) (rebased onto metadata53)#5215
joshmoore merged 26 commits intoome:metadata53from
atarkowska:rebased/metadata53/metadata52-render

Conversation

@atarkowska
Copy link
Copy Markdown
Member

This is the same as gh-4542 but rebased onto metadata53.


This was the same as gh-4385 gh-4430 but rebased onto metadata52. Now with additional commits.


See the bin/omero render -h output and the test for expected behavior. Primary driver for the creation of render.py was scripting the rendering settings along with the imports so that everything could be re-done if necessary:

PLATE=$(bin/omero import ... | grep Plate:)
bin/omero render copy Image:1 $PLATE

See IDR/idr-metadata#75 for information on the intended workflow for omero render edit.

Perhaps the main discussion point is the use of yaml/json for these settings, and the implementation of pydict_text_readers.py. load is designed to transparently handle:

  • json or yaml (former is stricter on types and is better for generated definitions, the latter is more user friendly if you're crafting it by hand)
  • /local/file/paths or remote OriginalFile:Ids
  • If you're happy with this design I'll re-use it in the metadata plugin.
  • For the future: could have json/yaml write methods which could tie in with the new obj/tree plugin CLI: graph extensions design#31 in which case pydict_text_readers.py should be renamed.

Additional commits implement omero render edit to allow rendering settings to be set on an image.

  • Editing of channel names isn't implemented yet, and tests are pending.
  • When testing this plugin I ran into several Too many open files errors on the server, and I'm not sure if it's an error in this code, a system misconfiguration, or an OMERO.server bug

@atarkowska
Copy link
Copy Markdown
Member Author

--rebased-from #4542

@joshmoore joshmoore merged commit 7fce6d5 into ome:metadata53 Apr 7, 2017
@joshmoore joshmoore deleted the rebased/metadata53/metadata52-render branch April 7, 2017 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants