render.py: new CLI plugin for dealing with rendering settings (manual rebase onto metadata52) (rebased onto metadata53)#5215
Merged
joshmoore merged 26 commits intoome:metadata53from Apr 7, 2017
atarkowska:rebased/metadata53/metadata52-render
Merged
render.py: new CLI plugin for dealing with rendering settings (manual rebase onto metadata52) (rebased onto metadata53)#5215joshmoore merged 26 commits intoome:metadata53from atarkowska:rebased/metadata53/metadata52-render
joshmoore merged 26 commits intoome:metadata53from
atarkowska:rebased/metadata53/metadata52-render
Conversation
It adds unnecessary complexity
Without this the content ("binary") is ignored
Merged
2 tasks
Member
Author
|
--rebased-from #4542 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as gh-4542 but rebased onto metadata53.
This was the same as gh-4385 gh-4430 but rebased onto
metadata52. Now with additional commits.See the
bin/omero render -houtput and the test for expected behavior. Primary driver for the creation ofrender.pywas scripting the rendering settings along with the imports so that everything could be re-done if necessary:See IDR/idr-metadata#75 for information on the intended workflow for
omero render edit.Perhaps the main discussion point is the use of yaml/json for these settings, and the implementation of
pydict_text_readers.py.loadis designed to transparently handle:/local/file/paths or remoteOriginalFile:Idsobj/treeplugin CLI: graph extensions design#31 in which casepydict_text_readers.pyshould be renamed.Additional commits implement
omero render editto allow rendering settings to be set on an image.Too many open fileserrors on the server, and I'm not sure if it's an error in this code, a system misconfiguration, or an OMERO.server bug