Fix render py (rebased onto metadata53) #5239
Merged
jburel merged 10 commits intoome:metadata53from Apr 11, 2017
atarkowska:rebased/metadata53/fix-render-py
Merged
Fix render py (rebased onto metadata53) #5239jburel merged 10 commits intoome:metadata53from atarkowska:rebased/metadata53/fix-render-py
jburel merged 10 commits intoome:metadata53from
atarkowska:rebased/metadata53/fix-render-py
Conversation
Member
Author
|
--rebased-from #4872 |
This was referenced Apr 10, 2017
Merged
A new "tracked service" internal API has been added. All calls to `_create_func` in `ProxyObjectWrapper` now registers the string reprenstation of the created service as well as the current call stack to the owning `BlitzGateway` instance. If on deletion, services are left open, then an ERROR message including the call stack will be printed.
The metadata plugin now takes a wait option as with graph operations and converts this into loop and ms settings to be passed to all write_to_omero methods (which internally use BaseClient.submit).
During plugin loading, loop over the contents of sys.path (i.e. PYTHONPATH) and for all directories which contain a subdirectory `omero/plugin` run the loadpath method as if it had been passed to `bin/omero` with `--path`. NB: This currently does not handle plugins packaged as eggs.
atarkowska
commented
Apr 10, 2017
| @assert_re() | ||
| def setActiveChannels(self, channels, windows=None, colors=None, | ||
| reverseMaps=None): | ||
| reverseMaps=None, noRE=False): |
Member
Author
There was a problem hiding this comment.
@joshmoore conflict were on noRE as reverseMaps were added in develop. This is something to review
Member
|
Note: this minimally leaves one very common situation where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as gh-4872 but rebased onto metadata53 and #4988 #5053 #5163
See jburel#11
This should fix the currently failing metadata52 tests.