Skip to content

Travis update#5409

Merged
sbesson merged 13 commits intoome:developfrom
jburel:travis-update
Aug 8, 2017
Merged

Travis update#5409
sbesson merged 13 commits intoome:developfrom
jburel:travis-update

Conversation

@jburel
Copy link
Copy Markdown
Member

@jburel jburel commented Aug 1, 2017

What this PR does

Use trusty to build
This is necessary to build with newer version of pytables
and newer version of ice

  • building using ant fails all the time, need to use ./build.py.
  • installation of python dependencies needs to be explicitly done via
    sudo apt-get during before_install: otherwise the dependencies will not be available to the container. This means that the python tests will fail with for example No module Ice. Change sudo option to required. I did not notice an increase in the build time with that change. See Issue with the Python path in the recent builds travis-ci/travis-ci#8048
  • update numexpr via pip to avoid some table test failure e.g.
    test/unit/tablestest/test_servants.py:349: will fail with ValueError: Using `oa_ndim == 0` when `op_axes` is NULL. Use `oa_ndim == -1` or the MultiNew iterator for NumPy <1.8 compatibility

Testing this PR

Check that travis is green

See https://trello.com/c/gVsUkLH8/100-travis-upgrade

@jburel jburel mentioned this pull request Aug 1, 2017
@jburel jburel force-pushed the travis-update branch 3 times, most recently from 2ea528f to dbc22d6 Compare August 2, 2017 20:19
@jburel jburel force-pushed the travis-update branch 14 times, most recently from a7487ea to 574452b Compare August 3, 2017 18:46
@jburel jburel force-pushed the travis-update branch 6 times, most recently from a85745c to da1f324 Compare August 4, 2017 06:40
@rleigh-codelibre
Copy link
Copy Markdown
Contributor

Looks generally OK.

I'm uncertain that sudo is required. Every package you are installing is in the trusty whitelist (https://github.com/travis-ci/apt-package-whitelist) because I requested them months ago and they have been available for a while now.

Did you find what build.py is doing which makes a difference? It's not related to sudo builds being run on different VMs?

@jburel jburel force-pushed the travis-update branch 3 times, most recently from 5906608 to 42c9ca3 Compare August 4, 2017 09:11
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Aug 4, 2017

without sudo: required it is not possible to install the python dependencies in before_install step.
When travis-ci/travis-ci#8048 is resolved we will probably have to revisit. Note that using group:edge as suggested in issue did not work

Other changes have been made.
The error might have been due to python dependencies not available
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Aug 4, 2017

@rleigh-codelibre works now with ant. Still unclear why it was not before (without explicit error it is tricky to figure error)

@jburel jburel mentioned this pull request Aug 7, 2017
@jburel
Copy link
Copy Markdown
Member Author

jburel commented Aug 7, 2017

@sbesson comment added to this PR too

@jburel
Copy link
Copy Markdown
Member Author

jburel commented Aug 18, 2017

--rebased-to #5447

@joshmoore joshmoore mentioned this pull request Aug 31, 2017
@sbesson sbesson added this to the 5.4.0 milestone Oct 6, 2017
@jburel jburel deleted the travis-update branch October 13, 2017 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants