Unwrap PermDetails for canChgrp/canChown detection#5437
Merged
joshmoore merged 1 commit intoome:developfrom Aug 16, 2017
Merged
Unwrap PermDetails for canChgrp/canChown detection#5437joshmoore merged 1 commit intoome:developfrom
joshmoore merged 1 commit intoome:developfrom
Conversation
PermDetails objects are being passed to the BasicACLVoter.postProcess method when `new map(x_details_permissions)` is used in the HQL query. Not having access to the original object confuses the security system leading to incorrect can* values. This permits unwrapping of internal PermDetails instances. See: * ome#3910 * https://trello.com/c/QbdB9M8k/115-canchgrp-canchown-bug
Merged
mtbc
approved these changes
Aug 15, 2017
Member
|
@will-moore should review too with respect to #5352. |
Member
|
Permissions tests now passing: https://ci.openmicroscopy.org/job/OMERO-DEV-merge-integration-Python27/630/testReport/OmeroPy.test.integration.test_permissions/ |
Member
Author
|
Merging this so that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PermDetails objects are being passed to the BasicACLVoter.postProcess
method when
new map(x_details_permissions)is used in the HQL query.Not having access to the original object confuses the security system
leading to incorrect can* values. This permits unwrapping of internal
PermDetails instances.
See:
What this PR does
IQuery.projection(new map(...))match those ofIQuery.get(...), e.g.Testing this PR
Trueis returned in both casesRelated reading