Fix SandboxTest.setUp() in case gh.git_repo() fails with a server error#115
Merged
joshmoore merged 1 commit intoome:masterfrom Nov 1, 2013
Merged
Fix SandboxTest.setUp() in case gh.git_repo() fails with a server error#115joshmoore merged 1 commit intoome:masterfrom
joshmoore merged 1 commit intoome:masterfrom
Conversation
If gh.git_repo() fails due to e.g. a server error, this commit ensures we return to the initial folder instead of staying in a deleted folder
Member
|
Who/what performed the |
Member
Author
|
No, I think the |
Member
|
Hmmmm.... that seems dangerous. Maybe we should remove all calls to |
Member
|
If that larger change needs to wait until after 0.4.1, then 👍 for this. |
Member
Author
|
If this PR doesn't harm, let's merge it maybe and then open an issue for the |
Member
|
Issue created. Merging. |
joshmoore
added a commit
that referenced
this pull request
Nov 1, 2013
Fix SandboxTest.setUp() in case gh.git_repo() fails with a server error
joshmoore
added a commit
to joshmoore/scc
that referenced
this pull request
Aug 29, 2018
joshmoore
added a commit
to joshmoore/scc
that referenced
this pull request
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
gh.git_repo()fails due to e.g. a server error, this commit ensures we return to the initial folder instead of staying in a deleted folderTo test this PR:
see http://hudson.openmicroscopy.org.uk/view/Failing/job/SCC-self-merge/142/console
we shouldn't get any
error if SandboxTest.setUp()` fails