✨ Quality: File streams not properly disposed on preview failure#120
Open
halinhtvn3a wants to merge 1 commit into
Conversation
The `PreviewFile` method opens a file stream with `File.Open()` but doesn't handle exceptions. If an exception occurs after opening the stream but before assignment to the `Document` property, the stream will leak. This is a resource leak that could cause file locking issues or exhaust file handles over time, especially when previewing problematic files. Affected files: RichTextViewer.xaml.cs Signed-off-by: halinhtvn3a <77691576+halinhtvn3a@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
PreviewFilemethod opens a file stream withFile.Open()but doesn't handle exceptions.If an exception occurs after opening the stream but before assignment to the
Documentproperty,the stream will leak. This is a resource leak that could cause file locking issues or
exhaust file handles over time, especially when previewing problematic files.
Severity:
mediumFile:
FileExplorer.Extension.RichTextPreview/RichTextViewer.xaml.csSolution
Wrap the file opening in a try-catch block to ensure proper disposal:
Changes
FileExplorer.Extension.RichTextPreview/RichTextViewer.xaml.cs(modified)Testing