Skip to content

Add update method for Account#34

Merged
danfowler merged 3 commits intomasterfrom
add-update-method-for-account
Aug 5, 2020
Merged

Add update method for Account#34
danfowler merged 3 commits intomasterfrom
add-update-method-for-account

Conversation

@danfowler
Copy link
Copy Markdown
Contributor

@danfowler danfowler commented Aug 4, 2020

  • Add input/output param docs for method
  • Add test
  • Add update method

@danfowler danfowler requested a review from rezigned August 5, 2020 02:22
Comment thread omise/test/test_account.py Outdated
}""")

self.assertTrue(isinstance(account, class_))
account.chain_enabled = True
Copy link
Copy Markdown

@rezigned rezigned Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should re-write these a bit to make it clearer.

self.assertFalse(account.chain_enabled)
account.update(chain_enabled=True)
self.assertTrue(account.chain_enabled)

Otherwise it looks like we just assign object's attribute directly (even though there's more stuff under the hood).

@danfowler danfowler merged commit c9b99ba into master Aug 5, 2020
@danfowler danfowler deleted the add-update-method-for-account branch August 5, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants