Skip to content

Removed logging secret key in clear text #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aashishgurung merged 1 commit into from
Nov 22, 2022
Merged

Removed logging secret key in clear text #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions omise/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ def send(self, method, path, payload=None, headers=None):
request_headers = self._build_headers(headers)

logger.info('Sending HTTP request: %s %s', method.upper(), request_path)
logger.debug('Authorization: %s', self.api_key)
logger.debug('Payload: %s', request_payload)
logger.debug('Headers: %s', request_headers)

Expand All @@ -108,7 +107,6 @@ def send_file(self, method, path, files=None, headers=None):
request_headers = self._build_file_header(headers)

logger.info('Sending HTTP request: %s %s', method.upper(), request_path)
logger.debug('Authorization: %s', self.api_key)
logger.debug('Files: %s', request_files)
logger.debug('Headers: %s', request_headers)

Expand Down Expand Up @@ -158,4 +156,4 @@ def _build_file_header(self, headers):
if self.api_version is not None:
headers['Omise-Version'] = self.api_version
headers['User-Agent'] = 'OmisePython/%s' % version.__VERSION__
return headers
return headers