Fix csrf_detect error with concurrent authorisations#88
Closed
ernesto-jimenez wants to merge 3 commits intoomniauth:masterfrom
Closed
Fix csrf_detect error with concurrent authorisations#88ernesto-jimenez wants to merge 3 commits intoomniauth:masterfrom
ernesto-jimenez wants to merge 3 commits intoomniauth:masterfrom
Conversation
Fixes csrf_detected happening when more than one authorization is started in several tabs, which means the session's "omniauth.state" is overridden.
Author
|
@sferik CI fails because one of the gems is not installing in Ruby 1.8.7 and JRuby 18 mode |
kwilczynski
pushed a commit
to paperlesspost/omniauth-oauth2
that referenced
this pull request
Sep 22, 2017
This commit adds changes against version 1.1.2 from an upstream patch, see: omniauth#88; for more details. Signed-off-by: Krzysztof Wilczynski <kw@paperlesspost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, if multiple authorisations are started in different tabs, only the latest will succeed since session's state is overridden each time an authorisation starts.
This fixes that issue by having multiple states within a session rather than just one.
Note: there could still be race conditions when the session information is store is a cookie and a second authorisation is started before the browser has stored the cookie from the first one.