Skip to content

Fix Notification for LoggingService and Show Cell Parameter in Seperate Notification #45

Merged
PeterHasse merged 14 commits intorel/0.5from
fix/logging_notification
Jan 8, 2025
Merged

Fix Notification for LoggingService and Show Cell Parameter in Seperate Notification #45
PeterHasse merged 14 commits intorel/0.5from
fix/logging_notification

Conversation

@hajoha
Copy link
Copy Markdown
Contributor

@hajoha hajoha commented Jan 8, 2025 •
edited
Loading

This PR contain:

Fixes

  • Resolved the notification bug: when LoggingService is disabled, the notification now disappears as expected.
  • Disabled LoggingService when enable_logging is set to false.
  • Corrected StringBuilder handling for LTE/NR information.

Additions

  • Introduced monitoring of data targets for logging:
    • Includes connection status to Influx; if connected, displays the status of writeApi in the notification.
    • Shows other logging targets (currently only File).
  • Moved the CellParameter notification from LoggingService to a dedicated NotificationService, allowing users to access it without enabling logging.

@hajoha hajoha self-assigned this Jan 8, 2025
@hajoha hajoha changed the title WIP: Fix Notification for LoggingService Draft: Fix Notification for LoggingService Jan 8, 2025
@hajoha hajoha marked this pull request as draft January 8, 2025 11:30
@hajoha hajoha changed the title Draft: Fix Notification for LoggingService Draft: Fix Notification for LoggingService and Show Cell Parameter in Seperate Notification Jan 8, 2025
@hajoha hajoha marked this pull request as ready for review January 8, 2025 16:17
@hajoha
Merge remote-tracking branch 'origin/rel/0.5' into fix/logging_notifi…
c43b637 
…cation

# Conflicts:
#	app/src/main/AndroidManifest.xml
@hajoha hajoha marked this pull request as draft January 8, 2025 16:24
@hajoha hajoha marked this pull request as ready for review January 8, 2025 16:58
@hajoha hajoha marked this pull request as draft January 8, 2025 16:59
@PeterHasse PeterHasse marked this pull request as ready for review January 8, 2025 17:00
PeterHasse
PeterHasse approved these changes Jan 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@PeterHasse PeterHasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PeterHasse PeterHasse merged commit e68be6a into rel/0.5 Jan 8, 2025
@PeterHasse PeterHasse deleted the fix/logging_notification branch January 8, 2025 17:05
@hajoha hajoha mentioned this pull request Jan 8, 2025
Closed
@hajoha hajoha changed the title Draft: Fix Notification for LoggingService and Show Cell Parameter in Seperate Notification Fix Notification for LoggingService and Show Cell Parameter in Seperate Notification Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterHasse PeterHasse PeterHasse approved these changes

Assignees

@hajoha hajoha

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hajoha @PeterHasse