This repository was archived by the owner on Dec 10, 2025. It is now read-only.
[lc0][SYCL] Fix segfault #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect dereference and assignment causing a segfault.
|
Greetings @rafbiels , I will take a look at this pull request and test it out internally. I will let you know if it is good to merge. |
|
Internal testing looks good, merging the PR |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect dereference and assignment causing a segfault. Also use the templated
malloc_deviceto avoid C-style casting and make the code clearer.The code creates an uninitialised pointer and intends to assign a value to this pointer (location of newly allocated memory). However, it was previously trying to assign the value to the pointed-to location not the pointer itself, hence it was dereferencing the uninitialised pointer.