fix: add explicit return and null check in getProp function#72
Open
Ayoub-Mabrouk wants to merge 2 commits intoonebeyond:masterfrom
Open
fix: add explicit return and null check in getProp function#72Ayoub-Mabrouk wants to merge 2 commits intoonebeyond:masterfrom
Ayoub-Mabrouk wants to merge 2 commits intoonebeyond:masterfrom
Conversation
- Add explicit return undefined for non-nested keys that don't exist - Add guard clause to prevent accessing properties on null/undefined objects - Improves robustness when accessing nested properties
Collaborator
|
Hey @Ayoub-Mabrouk! Thanks for all the contributions you are doing in systemic too! ❤️ Do you think that we can update the tests to reflect this change and prevent regressions in the future? Thanks in advance! |
Add tests to verify the getProp fix handles edge cases gracefully: - When first part of nested source path doesn't exist - When intermediate parts exist but final part doesn't exist - When component is null/undefined These tests prevent regressions and ensure the fix works correctly in the dependency injection flow where getProp is used.
Contributor
Author
Hello @UlisesGascon I've updated the PR to include tests covering the new behavior. Thanks for the feedback! 👍 |
UlisesGascon
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit return undefined for non-nested keys that don't exist
Add guard clause to prevent accessing properties on null/undefined objects
Improve robustness when accessing nested properties
Add tests to cover new behaviors and prevent regressions