Revert auto-scroll for Settings repository selection#303
Merged
Conversation
The auto-scroll behavior added in #301 doesn't feel right; drop the ScrollViewReader wiring and revert the sidebar list to its prior shape. The Cmd-W close shortcut from the same PR is kept intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScrollViewReader+.id(...)wiring added in Fix Settings window shortcuts and repo reveal #301 — the auto-scroll behavior in the Settings sidebar didn't feel right.Test plan
make build-appmake check