Skip to content

Fix toolbar title hover layout shift#324

Open
onevclaw wants to merge 1 commit into
mainfrom
onevclaw/issue-313-stable-toolbar-title
Open

Fix toolbar title hover layout shift#324
onevclaw wants to merge 1 commit into
mainfrom
onevclaw/issue-313-stable-toolbar-title

Conversation

@onevclaw
Copy link
Copy Markdown
Collaborator

Summary

  • Keep the branch rename pencil affordance in the toolbar title layout at all times
  • Toggle only the pencil opacity on hover so the title item keeps a stable intrinsic width

Verification

  • PATH="/Applications/Xcode-26.4.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin:$PATH" make check
  • make build-app

Fixes #313

if title.supportsRename && isHovered {
if title.supportsRename {
Image(systemName: "pencil")
.foregroundStyle(.secondary)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will render an empty space
Image

abhi21git added a commit to abhi21git/Prowl that referenced this pull request May 20, 2026
@abhi21git
Copy link
Copy Markdown

abhi21git commented May 20, 2026

Here is an alternative approach: #326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep the center PR/status pill stable when branch rename expands

2 participants