Skip to content

Resolve directories passed to flow init#2055

Merged
jribbink merged 1 commit intomasterfrom
jribbink/resolve-init-dir
Sep 15, 2025
Merged

Resolve directories passed to flow init#2055
jribbink merged 1 commit intomasterfrom
jribbink/resolve-init-dir

Conversation

@jribbink
Copy link
Contributor

@jribbink jribbink commented Sep 15, 2025

Closes #1756

Description

Resolves directories passed to flow init, including existing such as ..


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Sep 15, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/super/init.go 58.82% 4 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@chasefleming
Copy link
Member

Should there be a flag to bypass interactive prompts for the minimal setup?

@jribbink
Copy link
Contributor Author

jribbink commented Sep 15, 2025

Should there be a flag to bypass interactive prompts for the minimal setup?

Yeah I think we can add that, the goal with this PR was to just allow paths like . to be resolved correctly. I will make a new ticket for this.

EDIT: Tracking #2064

@jribbink jribbink merged commit 1ad0d69 into master Sep 15, 2025
11 checks passed
@jribbink jribbink deleted the jribbink/resolve-init-dir branch September 15, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flow init . does not work

4 participants