Add RandomTreesEmbedding feature#1839
Merged
MaxHalford merged 2 commits intoonline-ml:mainfrom Apr 28, 2026
Merged
Conversation
MaxHalford
reviewed
Apr 27, 2026
Member
MaxHalford
left a comment
There was a problem hiding this comment.
Nice! The one thing that's missing is that the implementation assumes features are scaled between [0, 1]. We need to document in every place where this assumption is made that the user should use a MinMaxScaler prior. See what I mean?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @MaxHalford,
if I understood the RamdomTreeEmbeddings correctly, this PR should implement them.
The crucial lines are the following, where the transforms_one methods returns a dictionary showing which leaf x ends up in for each tree.
Could you please briefly check it ?