1476 hoeffding races#1842
Open
kulbachcedric wants to merge 4 commits intoonline-ml:1476-hoeffding-racesfrom
Open
1476 hoeffding races#1842kulbachcedric wants to merge 4 commits intoonline-ml:1476-hoeffding-racesfrom
kulbachcedric wants to merge 4 commits intoonline-ml:1476-hoeffding-racesfrom
Conversation
MaxHalford
approved these changes
Apr 29, 2026
Member
MaxHalford
left a comment
MaxHalford
left a comment
There was a problem hiding this comment.
Nice! Approved with some comments. Also, don't forget to add an unreleased.md entry.
I'd love to benchmark this against the other model selection methods.
Comment on lines
+42
to
+43
| models: list[base.Estimator] | ||
| metric: metrics.base.Metric |
Member
There was a problem hiding this comment.
Are you confident here? It's not really a pattern we use elsewhere in the codebase, right? I think attributes you declare this way are shared by all instances.
I would be more inclined to simply instantiate a self._models and self._metric in the __init__.
Comment on lines
+129
to
+132
| @property | ||
| def n_active_models(self) -> int: | ||
| """The number of models still in the race.""" | ||
| return len(self._active) |
| def predict_proba_one(self, x): | ||
| return self.best_model.predict_proba_one(x) | ||
|
|
||
| @property |
Member
There was a problem hiding this comment.
I'm surprised this doesn't break anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Hoeffding Race Classifier and Regressor