Fix: iframe and sandbox retry mechanism by saddlepaddle · Pull Request #2986 · onlook-dev/onlook

saddlepaddle · 2025-10-09T21:03:19Z

Description

Have the script injection wait for the sandbox provider to be ready
Add extra retry logic for starting up a sandbox (we were still failing even with the server-side retries)
Allows the sandbox to still be accessible if the preload script injection fails (probably better than fully bricking the product)
(main issue) Prevent SessionManager from starting before sandboxmanager is ready

Related Issues

Type of Change

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

Bug Fixes
- Clear failure feedback when the project frame can’t connect, avoiding silent errors.
- More accurate preload readiness detection to reduce stuck loading overlays.
- Automatic retry for sandbox connections to minimize transient connection failures.
- Multi-branch restore: removed misleading success toast on partial success; shows an error if any restore fails.
Refactor
- Streamlined internal state management for preload and connection flow to improve reliability.

vercel · 2025-10-09T21:03:26Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
web	Ready	Preview	Comment	Oct 11, 2025 1:58am

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Oct 11, 2025 1:58am

supabase · 2025-10-09T21:03:26Z

This pull request has been ignored for the connected project wowaemfasoptxrdjhilu because there are no changes detected in apps/backend/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

coderabbitai · 2025-10-09T21:03:54Z

Caution

Review failed

The pull request is closed.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The description lists the main changes clearly but leaves the Related Issues section without any linked issue references, does not select the appropriate Type of Change checkbox, and lacks a Testing section describing verification steps. These missing elements are required by the repository template to trace issue context, identify the nature of the change, and validate functionality. Because these sections remain as placeholders, the description is incomplete. Filling in these sections will improve PR clarity and adherence to project standards.	Please link any related issues in the Related Issues section using GitHub keywords, mark the appropriate box under Type of Change to classify this PR, and provide details of the tests performed or steps to verify the changes in the Testing section.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly captures the main change of enforcing sequential sandbox loading to prevent lockouts, matching the pull request objectives. It is concise, specific, and describes the key fix without extraneous details. The phrasing aligns with the code modifications to session startup and script injection. Therefore it accurately summarizes the primary change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 256d36b and 672bdde.

📒 Files selected for processing (2)

apps/web/client/src/app/project/[id]/_components/canvas/frame/index.tsx (2 hunks)
apps/web/client/src/components/store/editor/sandbox/index.ts (5 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

...pp/project/[id]/_components/right-panel/chat-tab/chat-messages/multi-branch-revert-modal.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Kitenite · 2025-10-10T03:41:51Z

apps/web/client/src/components/store/editor/sandbox/index.ts

            console.error('[SandboxManager] Failed to ensure preload script exists:', error);
+            // Mark as injected to prevent blocking frames indefinitely
+            // Frames will handle the missing preload script gracefully
+            this.preloadScriptInjected = true;


should we do this in finally instead of doing both in try and catch?

in this case we should just remove this flag or merge it with the preloadScriptLoading flag

vercel bot temporarily deployed to Preview – docs October 9, 2025 21:03 Inactive

vercel bot deployed to Preview – web October 9, 2025 21:07 View deployment

vercel bot temporarily deployed to Preview – docs October 9, 2025 21:25 Inactive

vercel bot deployed to Preview – web October 9, 2025 21:28 View deployment

saddlepaddle commented Oct 9, 2025

View reviewed changes

...pp/project/[id]/_components/right-panel/chat-tab/chat-messages/multi-branch-revert-modal.tsx Show resolved Hide resolved

vercel bot temporarily deployed to Preview – docs October 9, 2025 21:35 Inactive

vercel bot deployed to Preview – web October 9, 2025 21:38 View deployment

saddlepaddle and others added 3 commits October 9, 2025 18:09

Fix git restore breaking by pausing sync during the restore

6b11c6c

Update apps/web/client/src/services/sync-engine/sync-engine.ts

457748c

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Fix pr feedback

e944991

saddlepaddle force-pushed the fix-git-restore-breaking branch from 6b7446b to e944991 Compare October 10, 2025 01:09

saddlepaddle added 3 commits October 9, 2025 18:17

New blank template works

f56c96a

Working

d6f3e0f

Cleanup

0a11a67

saddlepaddle force-pushed the min branch from 50f74e2 to 0a11a67 Compare October 10, 2025 01:18

vercel bot temporarily deployed to Preview – docs October 10, 2025 01:18 Inactive

vercel bot deployed to Preview – web October 10, 2025 01:21 View deployment

Base automatically changed from fix-git-restore-breaking to main October 10, 2025 02:58

Merge branch 'main' into min

256d36b

vercel bot temporarily deployed to Preview – docs October 10, 2025 03:40 Inactive

Kitenite reviewed Oct 10, 2025

View reviewed changes

vercel bot deployed to Preview – web October 10, 2025 03:43 View deployment

centralize preload script state

672bdde

vercel bot temporarily deployed to Preview – docs October 11, 2025 01:55 Inactive

vercel bot deployed to Preview – web October 11, 2025 01:58 View deployment

Kitenite merged commit cea4916 into main Oct 11, 2025
4 of 7 checks passed

Kitenite changed the title ~~Fix: ensure that sandbox loading steps occur sequentially to avoid locking out sandboxes~~ Fix: iframe and sandbox retry mechanism Oct 11, 2025

Kitenite deleted the min branch October 12, 2025 06:09

coderabbitai bot mentioned this pull request Mar 6, 2026

fix(sandbox): auto-bypass CSB free-tier trust interstitial and guard preload script race #3088

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: iframe and sandbox retry mechanism#2986

Fix: iframe and sandbox retry mechanism#2986
Kitenite merged 8 commits intomainfrom
min

saddlepaddle commented Oct 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

supabase bot commented Oct 9, 2025

Uh oh!

coderabbitai bot commented Oct 9, 2025 •

edited

Loading

Review failed

Uh oh!

Uh oh!

Kitenite Oct 10, 2025

Uh oh!

Kitenite Oct 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

saddlepaddle commented Oct 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Type of Change

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

Uh oh!

vercel bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase bot commented Oct 9, 2025

Uh oh!

coderabbitai bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

Kitenite Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Kitenite Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

saddlepaddle commented Oct 9, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Oct 9, 2025 •

edited

Loading

coderabbitai bot commented Oct 9, 2025 •

edited

Loading