Add ignore command #110
Merged
Add ignore command #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This did work for my use case. Thanks! But there are still some design questions that aren't clear to me. I'll add another comment to the issue. |
Member
|
I'd prefer to review this after the other two PRs that I just approved have been merged. |
Collaborator
Author
|
OK - the other PRs are merged, and I've updated this to be in sync with |
Member
|
Thanks. This look good, but I want to try it out for real before I mark as approved. |
jamesaoverton
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #108
This required changes to many of the modules, so I'd like this to be thoroughly tested before merging. I've already tried most of the commands out with an ignored sheet. @jamesaoverton could you try this with your use case?