Skip to content

Improve logging/messages when DROID is not yet installed as a GitHub App #141

@jamesaoverton

Description

@jamesaoverton

Today I debugged a problem with @anitacaron where she would click "Push", it would fail, and DROID would print a message to its console saying: 403 permission denied error from GitHub. She has write permissions on that GitHub repository, and was able to push commits using other tools. DROID was showing the version control buttons, so I think DROID was correctly reading her repository write permissions from GitHub. I think the cause is that her DROID GitHub App was not "installed" on that GitHub repository.

The DROID README has thorough documentation on the confusing process of setting up a GitHub App. It's easy to do that once and forget about it. But when a new project is added to DROID, DROID needs to be "installed" into that GitHub organization and/or repository. This can be easy to forget.

I think that DROID should be able to detect that it's not "installed". If it isn't installed, it should not display the list of branches or branch pages. It should just display a message with instructions for installing the GitHub App.

@lmcmicu Does my reasoning make sense to you?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions