-
Notifications
You must be signed in to change notification settings - Fork 79
new extract command method: subset #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think this now has the behaviour we expect, but I'm a bit worried about the efficiency of the approach used and what that might mean for scaling.
@balhoff - can you comment on this? |
robot-core/src/main/java/org/obolibrary/robot/ExtractOperation.java
Outdated
Show resolved
Hide resolved
|
@dosumis I commented about selecting object properties here: https://github.com/ontodev/robot/pull/1000/files#r871427940 |
|
@hkir-dev I would suggest making a separate PR for the OWL API upgrade. |
|
Here is the PR: https://github.com/ontodev/robot/pull/891/files Needs to be tested! High priority - I want to try to push this through by the end of the month.. |
|
@hkir-dev Where are we with this? Are there still blockers? Looks like was waiting for separate OWL-API update but this is now done? |
|
|
so it looks like a chain of dependencies - this requires a new owlapi version which depends on a new protege (if we want to continue syncing) - is there any way to progress independent of these |
|
Apparently in relation-graph I am using a method added in a newer OWL API compared to the current ROBOT release. I can work around that and make a new RG release. I think we got hung up because RG needs |
|
Protege is using Owl-API There are some significant improvements in Owl-API |
|
Everything needs to go to 4.5.22 or later no matter what - no need to bother with 4.5.19. Protege should be upgraded. |
|
OWL API upgrade merged to this branch. |
|
Thanks @hkir-dev, this looks great. I made some small changes. I'll merge it. In the future, you are welcome to make branches on this repository rather than your fork. It make life a little easier for me. |
Resolves [#497, resolves #497]
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedAdds new
subsetmethod to the extract operation:robot extract --method subsetLogic of the method is as follows:
To achieve this relation-graph dependency added to the ROBOT. Owl-api version increased to
4.5.9. Following files updated to fix the errors raised after the owl-api version upgrade: