refactor validate method to enable reading table from stream #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesaoverton
approved these changes
Dec 2, 2024
Member
jamesaoverton
left a comment
jamesaoverton
left a comment
There was a problem hiding this comment.
I just skimmed it, but it looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a pet project of mine (https://github.com/mapping-commons/sssom-validate-ui) I would like to be able to validate TSVs from a stream rather than a file. This PR mainly refactors the code so that the main operation operates on a stream rather than a file - and updates the code to a few new flake8 and black rules.
I have tested the code in my application, and I ran tox. I installed the code locally and ran a few tests as well. it looks ok!