ampersand encoding fixes #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2022
Merged
aim97
approved these changes
Nov 22, 2022
|
@oozcitak Would you mind merging and releasing this fix? Thanks! 🙌 |
Collaborator
|
Hello, folks. I'm a new co-maintainer for I've been talking with @oozcitak about transitioning some maintenance responsibilities to me, and as soon as I'm added as a maintainer on npm I'll ship this bug fix, which I've been using in production for several months. |
|
Exciting! This might also fix #117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
Fix for #109 & #110
Builds on the work started in #124. Notably, my changes cause @coffeemakr's added tests to pass.
I noticed this regex pattern was repeated multiple times, so I chose to define it once for import. Not married to this approach. Open to your thoughts.