Skip to content

Use services fqdn instead of IPs for intra Pod communication #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgoerens merged 3 commits into from
Sep 29, 2022
Merged

Use services fqdn instead of IPs for intra Pod communication #49

mgoerens merged 3 commits into from
Sep 29, 2022

Conversation

@mgoerens
Copy link
Collaborator

@mgoerens mgoerens commented Jul 20, 2022

closes #42

mgoerens added 3 commits July 20, 2022 12:49
@mgoerens
Use Services' FQDN for intra Pods communication
91d0fc2 
Synapse, Heisenbridge, and mautrix-signal are now setup to communicate
with each others using their respective Services' FQDN, rather than the
Service IP.
@mgoerens
Remove Services' IP from Synapse Status
fe9e7a3 
This information is not needed anymore, as we are now using the
Services' FQDN for intra Pod communication.
@mgoerens
Reconciliate Service with related resources
3194337 
Following the use of Services' FQDN instead of IP, it is not needed
anymore to create the Service first, and wait for an IP to be set. We
can reconcile the Services (for Synapse, Heisenbridge, and
mautrix-signal) together with their related resources.

This makes the controller reconciliation more trivial.
@opdevbot
Copy link

opdevbot commented Jul 20, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgoerens
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgoerens mgoerens changed the title Use services fqdn instead of IPs Use services fqdn instead of IPs for intra Pod communication Jul 20, 2022
@mgoerens mgoerens linked an issue Jul 21, 2022 that may be closed by this pull request
Use kubernetes Services FQDN rather than IPs #39
Closed
@mgoerens mgoerens requested a review from acmenezes July 21, 2022 15:10
@mgoerens mgoerens merged commit 72cd5d4 into master Sep 29, 2022
@exe-prow-github-app exe-prow-github-app bot deleted the use_services_fqdn branch September 29, 2022 14:31
@mgoerens mgoerens restored the use_services_fqdn branch September 29, 2022 14:32
@mgoerens mgoerens deleted the use_services_fqdn branch September 29, 2022 14:41
@mgoerens mgoerens restored the use_services_fqdn branch November 8, 2022 18:23
@mgoerens mgoerens deleted the use_services_fqdn branch November 8, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acmenezes acmenezes Awaiting requested review from acmenezes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Meaningful Synapse.Status.State Use kubernetes Services FQDN rather than IPs

4 participants

@mgoerens @opdevbot @acmenezes