This repository was archived by the owner on Jul 11, 2025. It is now read-only.
Disk-based job system and improved analysis#57
Merged
ConnectedSystems merged 13 commits intomainfrom Apr 29, 2025
Merged
Conversation
Previous address did not work/was confusing
Was unnecessary and confused users
Previously the polygon was rotated to align with the identified reef edge and only rotated a certain number of times to reduce computational cost. However, the reef edge was based on the available outlines which are problematic in some cases as they may not represent the actual reef edge (when compared to the bathymetry data). Instead, we rotate and assess the polygon in steps of 10 degrees to identify the approximately optimal rotation.
Collaborator
Author
|
FYI @arlowhite am merging this now. Datasets being uploaded too as discussed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a naive disk-based job system to avoid duplicate work being triggered.
Also mingled into this PR (bad practice I know) are improvements to the analyses for accuracy.
These changes depend on an updated dataset that will be made available shortly.
In short:
We now search for an approximately optimal candidate location by assessing rotations of their indicative polygons in steps of 10 degrees (this is somewhat arbitrary to balance computational cost, and can be adjusted).
The previous implementation heavily favoured straight vertical/horizonal rotations
The reason for this turned out to be the vector representation of the raster, which defaults to the bottom left corner of each pixel rather than the centroid:
Correcting this resulted in more accurate and diverse rotations: