Skip to content
This repository was archived by the owner on Jul 11, 2025. It is now read-only.

chore: tidy up and refactoring#68

Merged
PeterBaker0 merged 5 commits intofeat/adding-missing-criteriafrom
feat/cleanup-old-func
May 30, 2025
Merged

chore: tidy up and refactoring#68
PeterBaker0 merged 5 commits intofeat/adding-missing-criteriafrom
feat/cleanup-old-func

Conversation

@PeterBaker0
Copy link
Copy Markdown
Collaborator

Removes all methods I could identify as being completely unused/deprecated. I.e.

  • all previous job management system
  • all previous job routes
  • all previous regional/suitability API routes

Also removes a bunch of multiple dispatched wrappers of some of the assessment methods that were unused.

Moves a bunch of files around to try and make code structure a bit clearer, i.e.

  • applies a barrel import approach similar to TS, top level imports index.jl files, then index.jl files include that modules files
  • moves the modules dependencies into the index.jl file, since they were often stealthily shared between the files within a module anyway (making them sensitive to the order in which includes were executed)
  • tries to rename files/restructure to remove duplication, and make files have a single purpose where possible

NOTE: some methods I deleted we may want to retain (possibly for exposing some testing functionality/use cases I wasn't aware of). I've gone for the 'if unsure, delete' approach - but we can selectively bring stuff back if there is a good reason for it being there.

Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Copy link
Copy Markdown
Collaborator

@ConnectedSystems ConnectedSystems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments to maintain Julia conventions.

Thanks for cleaning out the cruft!

Comment thread src/ReefGuideAPI.jl Outdated
Comment thread src/assessment_methods/apply_criteria.jl Outdated
Comment thread src/assessment_methods/apply_criteria.jl Outdated
Comment thread src/assessment_methods/apply_criteria.jl
Comment thread src/job_worker/index.jl
PeterBaker0 and others added 2 commits May 30, 2025 09:08
Co-authored-by: Takuya Iwanaga <takuyai@gmail.com>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
@PeterBaker0 PeterBaker0 merged commit 75bb861 into feat/adding-missing-criteria May 30, 2025
1 check failed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants