This repository was archived by the owner on Jul 11, 2025. It is now read-only.
chore: tidy up and refactoring#68
Merged
PeterBaker0 merged 5 commits intofeat/adding-missing-criteriafrom May 30, 2025
Merged
Conversation
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
ConnectedSystems
suggested changes
May 29, 2025
Collaborator
ConnectedSystems
left a comment
There was a problem hiding this comment.
Minor comments to maintain Julia conventions.
Thanks for cleaning out the cruft!
Co-authored-by: Takuya Iwanaga <takuyai@gmail.com>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all methods I could identify as being completely unused/deprecated. I.e.
Also removes a bunch of multiple dispatched wrappers of some of the assessment methods that were unused.
Moves a bunch of files around to try and make code structure a bit clearer, i.e.
NOTE: some methods I deleted we may want to retain (possibly for exposing some testing functionality/use cases I wasn't aware of). I've gone for the 'if unsure, delete' approach - but we can selectively bring stuff back if there is a good reason for it being there.