Skip to content
This repository was archived by the owner on Jul 11, 2025. It is now read-only.

Adding other display information#70

Merged
PeterBaker0 merged 6 commits intofeat/adding-missing-criteriafrom
feat/adding-more-slider-info
Jun 4, 2025
Merged

Adding other display information#70
PeterBaker0 merged 6 commits intofeat/adding-missing-criteriafrom
feat/adding-more-slider-info

Conversation

@PeterBaker0
Copy link
Copy Markdown
Collaborator

Current response indicated below - will fill out TODOs

Adds id, display title/subtitle, units, default min/max, and payload prop prefix (for building jobs) into the dictionary.

{
  "Turbidity": {
    "id": "Turbidity",
    "min_val": 1,
    "max_val": 969,
    "display_title": "Turbidity",
    "display_subtitle": "TODO",
    "units": "TODO",
    "default_min_val": 1,
    "default_max_val": 969,
    "payload_property_prefix": "turbidity_"
  },
  "WavesTp": {
    "id": "WavesTp",
    "min_val": 1.4799601,
    "max_val": 10.763558,
    "display_title": "Wave Period (s)",
    "display_subtitle": "TODO",
    "units": "TODO",
    "default_min_val": 0,
    "default_max_val": 6,
    "payload_property_prefix": "waves_period_"
  },
  "WavesHs": {
    "id": "WavesHs",
    "min_val": 0.16966935,
    "max_val": 3.3906436,
    "display_title": "Wave Height (m)",
    "display_subtitle": "TODO",
    "units": "TODO",
    "default_min_val": 0,
    "default_max_val": 1,
    "payload_property_prefix": "waves_height_"
  },
  "Slope": {
    "id": "Slope",
    "min_val": 0.012705713,
    "max_val": 47.122066,
    "display_title": "Slope",
    "display_subtitle": "TODO",
    "units": "TODO",
    "default_min_val": 0.012705713,
    "default_max_val": 47.122066,
    "payload_property_prefix": "slope_"
  },
  "Depth": {
    "id": "Depth",
    "min_val": -17.897633,
    "max_val": -0.025795916,
    "display_title": "Depth",
    "display_subtitle": "TODO",
    "units": "TODO",
    "default_min_val": -10,
    "default_max_val": -2,
    "payload_property_prefix": "depth_"
  }
}

Signed-off-by: Peter Baker <peter.baker122@csiro.au>
@arlowhite
Copy link
Copy Markdown
Contributor

arlowhite commented Jun 3, 2025

I was thinking that ${id}_min would be implicit convention rather than needing payload_property_prefix, but it's fine if you want to be explicit about that.
EDIT: nevermind, id is the original id for this repo, which is different from JSON property style.

Also, do we have a plan for a subtitle? display_subtitle subtitle VS description? Maybe don't worry about it til we actually have text, but if you have plans, add it now.

Comment thread src/utility/routes.jl Outdated
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
ConnectedSystems and others added 3 commits June 3, 2025 17:44
TODO: Double check the percentile values for Hs and Tp (waves)
Swap tooltip text

Co-authored-by: Peter Baker <87056634+PeterBaker0@users.noreply.github.com>
@PeterBaker0 PeterBaker0 merged commit 49de9a6 into feat/adding-missing-criteria Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants