This repository was archived by the owner on Jul 11, 2025. It is now read-only.
Merged
Conversation
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
Collaborator
ConnectedSystems
left a comment
ConnectedSystems
left a comment
There was a problem hiding this comment.
LGTM, two minor comments then can be merged.
README.md
Outdated
| Setup env file: | ||
|
|
||
| ``` | ||
| cp .env.dist .env |
Collaborator
There was a problem hiding this comment.
Is it worthwhile making the filename explicit?
Suggested change
| cp .env.dist .env | |
| cp .env.dist .env.local |
Collaborator
Author
There was a problem hiding this comment.
.env being the 'active' environment is convention, but maybe .env.dist could be .env.local instead. I'll play that.
Co-authored-by: Takuya Iwanaga <takuyai@gmail.com>
Signed-off-by: Peter Baker <peter.baker122@csiro.au>
….jl into feat/minio-dropin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a minio s3 layer which is opt-in from the environment.
This allows a totally local stack in conjunction with in-progress PR for reefguide (in which we host the s3 bucket on localhost:9000 using minio, and the API on localhost:5000).