Skip to content

rerun advection-diffusion-2d and -1d notebooks; fix hdf5-mpi paths on macOS CI (homebrew); cleanup Trixi comparison notebook; pin CI upper Python version to 3.13.12 (since 3.13.13 errs with a base64 failure)#681

Merged
slayoo merged 5 commits intoopen-atmos:mainfrom
AgnieszkaZaba:rerun
May 1, 2026

Conversation

@AgnieszkaZaba
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.93%. Comparing base (34fe8d8) to head (e490d2f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files          40       40           
  Lines        1754     1754           
=======================================
  Hits         1630     1630           
  Misses        124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AgnieszkaZaba
Copy link
Copy Markdown
Collaborator Author

AgnieszkaZaba commented Apr 28, 2026

@slayoo slayoo changed the title rerun notebooks rerun advection-diffusion-2d and -1d notebooks (fixing Invalid notebook error on Github render); fix hdf5-mpi paths on macOS CI (homebrew related) Apr 28, 2026
@slayoo
Copy link
Copy Markdown
Member

slayoo commented Apr 29, 2026

rerunning as the Trixi issue seems to have been fixed in trixi-framework/Trixi.jl#2976

For the record, this is the error in CI:

ERROR: LoadError: TypeError: non-boolean (Static.True) used in boolean context Stacktrace: [1] _all(f::typeof(identity), itr::NTuple{4, Static.True}, ::Colon) 
@ Base ./anyall.jl:201 [2] all(f::Function, itr::NTuple{4, Static.True}) 
@ Base ./anyall.jl:212 [3] all(itr::NTuple{4, Static.True}) 
@ Base ./anyall.jl:80 [4] _offset_ptr 
@ ~/.julia/packages/StrideArraysCore/t77vK/src/ptr_array.jl:972 [inlined] [5] unsafe_getindex 
@ ~/.julia/packages/StrideArraysCore/t77vK/src/ptr_array.jl:980 [inlined] [6] getindex 
@ ~/.julia/packages/StrideArraysCore/t77vK/src/ptr_array.jl:1015 [inlined] [7] #get_node_vars##0 
@ ~/.julia/packages/Trixi/ZQJee/src/solvers/dg.jl:1066 [inlined] [8] ntuple 
@ ./ntuple.jl:50 [inlined] [9] get_node_vars 
@ ~/.julia/packages/Trixi/ZQJee/src/solvers/dg.jl:1066 [inlined] [10] weak_form_kernel! 
...

@slayoo slayoo changed the title rerun advection-diffusion-2d and -1d notebooks (fixing Invalid notebook error on Github render); fix hdf5-mpi paths on macOS CI (homebrew related) rerun advection-diffusion-2d and -1d notebooks (fixing Invalid notebook error on Github render); fix hdf5-mpi paths on macOS CI (homebrew related); fixes in Trixi comparison notebook Apr 29, 2026
@slayoo
Copy link
Copy Markdown
Member

slayoo commented Apr 29, 2026

the issue here is that the fix in Trixi was committed after the v0.16.6 release, so we need to wait for v0.16.7...

@JoshuaLampert
Copy link
Copy Markdown

The issue should be fixed upstream. So Trixi.jl v0.16.6 should be fine again.

@slayoo
Copy link
Copy Markdown
Member

slayoo commented Apr 29, 2026

@JoshuaLampert, thanks for following up here!

@slayoo
Copy link
Copy Markdown
Member

slayoo commented May 1, 2026

the base64 issue might be related with changes introduced in Python in 3.13.13: python/cpython#145264

@slayoo slayoo changed the title rerun advection-diffusion-2d and -1d notebooks (fixing Invalid notebook error on Github render); fix hdf5-mpi paths on macOS CI (homebrew related); fixes in Trixi comparison notebook rerun advection-diffusion-2d and -1d notebooks (fixing Invalid notebook error on Github render); fix hdf5-mpi paths on macOS CI (homebrew); cleanup Trixi comparison notebook; pin CI upper Python version to 3.13.12 (since 3.13.13 errs with a base64 failure) May 1, 2026
@slayoo slayoo added this pull request to the merge queue May 1, 2026
Merged via the queue into open-atmos:main with commit 47d7f82 May 1, 2026
55 of 56 checks passed
@AgnieszkaZaba
Copy link
Copy Markdown
Collaborator Author

@JoshuaLampert @slayoo Thank you!

@AgnieszkaZaba AgnieszkaZaba deleted the rerun branch May 2, 2026 14:09
@AgnieszkaZaba AgnieszkaZaba changed the title rerun advection-diffusion-2d and -1d notebooks (fixing Invalid notebook error on Github render); fix hdf5-mpi paths on macOS CI (homebrew); cleanup Trixi comparison notebook; pin CI upper Python version to 3.13.12 (since 3.13.13 errs with a base64 failure) rerun advection-diffusion-2d and -1d notebooks; fix hdf5-mpi paths on macOS CI (homebrew); cleanup Trixi comparison notebook; pin CI upper Python version to 3.13.12 (since 3.13.13 errs with a base64 failure) May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants