fix: prevent invalidation of allowlisted certificates [BB-4287]#369
Merged
Agrendalath merged 1 commit intoopencraft-release/koa.3from Jul 7, 2021
Conversation
The allowlisted certificates were getting invalidated upon visiting the Course Progress page by users. This is a rough backport of the Lilac fix (edx#26356). In Lilac, this is gated by the `certificates_revamp.use_allowlist` Waffle flag. In post-Lilac branches, this is working out of the box (the flag has been removed in edx#27576). Jira ticket: BB-4287
giovannicimolin
approved these changes
Jul 6, 2021
giovannicimolin
left a comment
There was a problem hiding this comment.
👍
- I tested this:
- Set up using the provided instructions.
- Checked that a certificate was generated, even without passing grades.
- Went through a full flow (register->purchase->verify) and then added the user in the cert whitelist.
- Checked that the certificate works.
- I read through the code
-
I checked for accessibility issuesNA -
Includes documentationNA
@Agrendalath Nice work! Good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allowlisted certificates were getting invalidated upon visiting the Course Progress page by users.
This is a rough backport of the Lilac fix (edx#26356). In Lilac, this is gated by the
certificates_revamp.use_allowlistWaffle flag. In post-Lilac branches, this is working out of the box (the flag has been removed in edx#27576).Note: if you are using the Lilac release, you don't need these changes - you can get them by enabling the certificates_revamp.use_allowlist flag in Django admin
Testing instructions
FEATURES['CERTIFICATES_HTML_VIEW'] = Trueto{lms,cms}/envs/private.py.verifiedwith the statusapproved.certificates.auto_certificate_generation, marked asActive.student.courseenrollment_admin, marked asActive.verified: fromaudittoverified.All users on the Exception listand click the "Generate Exception Certificates" button (if theverified@example.comuser is not in the list below the button, you should add it).verified@example.com, visit the dashboard, and use the "View Certificate" button (it should be under the course listing item).