Problem Builder: Add instance-wide option to hide previous answers for MCQs #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocks works in both Apros and the LMS.
| var steps = runtime.children(element).filter(function(c) { return c.element.className.indexOf('assessment_step_view') > -1; }); | ||
| var steps = runtime.children(element).filter(function(c) { | ||
| return $(c.element).attr("class").indexOf('assessment_step_view') > -1; | ||
| }); |
Member
There was a problem hiding this comment.
In case you're wondering why you had to make this change: https://openedx.atlassian.net/browse/TNL-4161
I believe the earlier version is "better" but it doesn't work with the latest edx-platform master. The new version you have here should always work, so we may as well keep this change.
Member
|
@itsjeyd Just a couple of comments. |
itsjeyd
force-pushed
the
hide-previous-answer
branch
from
1b1728e to
d2397fb
Compare
Member
|
👍 Though please squash at least some of the commits first. |
MCQs are shown when users revisit them.
- Fix existing tests. - Add unit tests for code that deals with instance-wide options. - Add integration test for scenario where previous answers for MCQs are configured to be hidden.
- Refactor: Take advantage of mixins from xblock-utils accessing xblock settings.
itsjeyd
force-pushed
the
hide-previous-answer
branch
from
d2397fb to
b17c0ee
Compare
Member
Author
|
@Kelketek Thanks, done. |
itsjeyd
added a commit
that referenced
this pull request
Feb 29, 2016
Problem Builder: Add instance-wide option to hide previous answers for MCQs
| @@ -63,6 +64,10 @@ | |||
| 'locations': ['public/themes/lms.css'] | |||
Member
There was a problem hiding this comment.
@itsjeyd Is this _default_theme_config being used? Looks to me like with ThemableXBlockMixin you need to define default_theme_config as an attribute on the class instead.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an instance-wide option to hide previous answers (and feedback) for MCQs in Problem Builder. When this option is enabled, students will still receive per-question feedback after providing answers to MCQs and submitting the containing block, but that feedback will not be visible when they return to the block, and all choices for a given MCQ will be unchecked.
cf. MCKIN-3861
Screenshots: LMS
Default settings:
Previous answers hidden:
Screenshots: Apros
Default settings:
Previous answers hidden:
Test instructions
Create a subsection with two units and add a Problem Builder block to each one.
Add a long answer, MCQ, Rating, MRQ, and Slider to one of the Problem Builder blocks.
Publish the units.
In LMS/Apros, provide answers to all questions and click "Submit".
Navigate to the other unit, then come back to the first unit. Observe that Problem Builder shows previous answers and feedback for all questions.
In
lms.env.json, enable the new option by modifying theXBLOCK_SETTINGSformentoring:Restart LMS/Apros and reload the page showing the first unit. Observe that Problem Builder does not show previous answers and feedback for MCQs.